Skip to content

[https://nvbugs/6427411][chore] Waive a failed test in Pre-merge#16105

Merged
shuyixiong merged 1 commit into
NVIDIA:mainfrom
shuyixiong:waive_pp_test1
Jul 8, 2026
Merged

[https://nvbugs/6427411][chore] Waive a failed test in Pre-merge#16105
shuyixiong merged 1 commit into
NVIDIA:mainfrom
shuyixiong:waive_pp_test1

Conversation

@shuyixiong

@shuyixiong shuyixiong commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Tests
    • Added a new test waiver entry for a specific Llama 3.1 8B Instruct FP8 multi-GPU variant, aligning it with an existing tracked issue.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Shuyi Xiong <219646547+shuyixiong@users.noreply.github.com>
@shuyixiong

Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Waive test"

@shuyixiong shuyixiong changed the title [None][chore] Waive tests [None][chore] Waive a failed test in Pre-merge Jul 8, 2026
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Added a single new waiver entry in the integration test waiver list, skipping a specific parameterized variant of the test_fp8_4gpus test for TestLlama3_1_8BInstruct, referencing bug nvbugs/6427411.

Changes

Waiver list update

Layer / File(s) Summary
Add new test skip entry
tests/integration/test_lists/waives.txt
Adds a SKIP entry for TestLlama3_1_8BInstruct::test_fp8_4gpus with tp2pp2-fp8kv=True-attn_backend=TRTLLM-torch_compile=False parameterization, referencing nvbugs/6427411.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: EmmaQiaoCh, yuxianq, dongxuy04

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is mostly the unfilled template and does not explain the issue, solution, or test coverage. Add a short problem/solution summary and fill in Test Coverage with the relevant tests or waiver rationale.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title is concise, specific, and matches the waiver change with a valid NVBugs tag and chore type.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@shuyixiong shuyixiong changed the title [None][chore] Waive a failed test in Pre-merge [https://nvbugs/6427411][chore] Waive a failed test in Pre-merge Jul 8, 2026
@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58173 [ skip ] triggered by Bot. Commit: 26fdfdc Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #58173 [ skip ] completed with state SUCCESS. Commit: 26fdfdc
Skipping testing for commit 26fdfdc

Link to invocation

@shuyixiong shuyixiong enabled auto-merge (squash) July 8, 2026 06:12
@shuyixiong shuyixiong merged commit 367653e into NVIDIA:main Jul 8, 2026
20 of 21 checks passed
BrianLi23 pushed a commit to BrianLi23/TensorRT-LLM that referenced this pull request Jul 9, 2026
…DIA#16105)

Signed-off-by: Shuyi Xiong <219646547+shuyixiong@users.noreply.github.com>
mingyangHao added a commit to mingyangHao/TensorRT-LLM that referenced this pull request Jul 9, 2026
Remove the PP sampler waivers introduced by NVIDIA#16103, NVIDIA#16105, NVIDIA#16127, and NVIDIA#16146. Also remove overlapping PP and gpu2 waivers from NVIDIA#16109 so the restored pre-NVIDIA#15920 sampler path is exercised in CI.

Signed-off-by: Mingyang Hao <200044211+mingyangHao@users.noreply.github.com>
mingyangHao added a commit to mingyangHao/TensorRT-LLM that referenced this pull request Jul 9, 2026
Remove the PP sampler waivers introduced by NVIDIA#16103, NVIDIA#16105, NVIDIA#16127, and NVIDIA#16146. Also remove overlapping PP and gpu2 waivers from NVIDIA#16109, plus the PP2 waiver added by NVIDIA#16169, so the restored pre-NVIDIA#15920 sampler path is exercised in CI.

Signed-off-by: Mingyang Hao <200044211+mingyangHao@users.noreply.github.com>
mingyangHao added a commit to mingyangHao/TensorRT-LLM that referenced this pull request Jul 9, 2026
Remove the PP sampler waivers introduced by NVIDIA#16103, NVIDIA#16105, NVIDIA#16127, and NVIDIA#16146. Also remove overlapping PP and gpu2 waivers from NVIDIA#16109, plus the PP2 waiver added by NVIDIA#16169, so the restored pre-NVIDIA#15920 sampler path is exercised in CI.

Signed-off-by: Mingyang Hao <200044211+mingyangHao@users.noreply.github.com>
@coderabbitai coderabbitai Bot mentioned this pull request Jul 9, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants