[None][infra] Waive 23 failed cases for main in post-merge 2826#16109
Conversation
Bug(s): 6428002, 6428005, 6428008, 6428014, 6428057, 6428063, 6428069, 6428087, 6428089, 6428091, 6428092, 6428094, 6428096, 6428101, 6428113, 6428124, 6428144 Requested by: @mzweilz Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
|
/bot skip --comment "Waive only" |
📝 WalkthroughWalkthroughThis PR updates the CI waive list (tests/integration/test_lists/waives.txt), adding new SKIP entries and removing/replacing prior ones for various failing or unsupported distributed test configurations across accuracy, disaggregated serving, kv_cache, perf sanity, and unittest suites. ChangesTest waiver list updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/integration/test_lists/waives.txt`:
- Around line 458-460: The current gpu2 waives are too broad because they skip
every pytest.mark.gpu2 test in the affected modules. Update the entries in the
waives list to target only the specific flaky nodeids in
unittest/llmapi/test_additional_model_outputs.py and
unittest/llmapi/test_llm_multi_gpu_pytorch.py, rather than module-wide -m "gpu2"
selectors. Keep the existing isolated test waiver for
test_additional_model_outputs_integration_pp2 unchanged if that is the only
failing case.
- Around line 425-426: The waive is too broad because it skips the entire
unittest/_torch/modules/test_moe_routing.py module instead of only the failing
tests. Update the entries in waives.txt to target the specific pytest node IDs
that are actually failing, using the existing test_moe_routing module name as
the locator, so unaffected cases like test_default_moe_routing and
test_load_balanced_moe_routing keep running.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 46daca07-20cf-4369-86bc-c2289b6f51e6
📒 Files selected for processing (1)
tests/integration/test_lists/waives.txt
|
PR_Github #58187 [ skip ] triggered by Bot. Commit: |
|
PR_Github #58187 [ skip ] completed with state |
Signed-off-by: Abby Wei <18545893+mzweilz@users.noreply.github.com>
Signed-off-by: Abby Wei <18545893+mzweilz@users.noreply.github.com>
|
/bot skip --comment "Waive only" |
|
PR_Github #58205 [ skip ] triggered by Bot. Commit: |
|
PR_Github #58205 [ skip ] completed with state |
…IA#16109) Signed-off-by: trtllm-agent <296075020+trtllm-agent@users.noreply.github.com>
Remove the PP sampler waivers introduced by NVIDIA#16103, NVIDIA#16105, NVIDIA#16127, and NVIDIA#16146. Also remove overlapping PP and gpu2 waivers from NVIDIA#16109 so the restored pre-NVIDIA#15920 sampler path is exercised in CI. Signed-off-by: Mingyang Hao <200044211+mingyangHao@users.noreply.github.com>
Remove the PP sampler waivers introduced by NVIDIA#16103, NVIDIA#16105, NVIDIA#16127, and NVIDIA#16146. Also remove overlapping PP and gpu2 waivers from NVIDIA#16109, plus the PP2 waiver added by NVIDIA#16169, so the restored pre-NVIDIA#15920 sampler path is exercised in CI. Signed-off-by: Mingyang Hao <200044211+mingyangHao@users.noreply.github.com>
Remove the PP sampler waivers introduced by NVIDIA#16103, NVIDIA#16105, NVIDIA#16127, and NVIDIA#16146. Also remove overlapping PP and gpu2 waivers from NVIDIA#16109, plus the PP2 waiver added by NVIDIA#16169, so the restored pre-NVIDIA#15920 sampler path is exercised in CI. Signed-off-by: Mingyang Hao <200044211+mingyangHao@users.noreply.github.com>
Auto-generated Waive PR
Created by: TensorRT LLM CI Report (requested by @mzweilz)
Target branch:
mainBug(s): 6428002, 6428005, 6428008, 6428014, 6428057, 6428063, 6428069, 6428087, 6428089, 6428091, 6428092, 6428094, 6428096, 6428101, 6428113, 6428124, 6428144
Waive entries added
Already waived (skipped)
accuracy/test_llm_api_pytorch_multimodal.py::TestNanoV3Omni::test_auto_dtype[nvfp4]This PR was auto-generated by TensorRT LLM CI Report. Please review the waive entries before merging.
Summary by CodeRabbit