fix: typo and unnecessary f-string in BRCM skip message - #3370
Merged
cyanguwa merged 1 commit intoAug 13, 2026
Conversation
Contributor
Greptile SummaryThe PR corrects the “dropouts” typo in the BRCM skip message and removes unnecessary f-string prefixes from three static skip messages.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "fix: typo and unnecessary f-string in BR..." | Re-trigger Greptile |
cyanguwa
reviewed
Aug 13, 2026
cyanguwa
left a comment
Collaborator
There was a problem hiding this comment.
This is a good catch, but for consistency, we could remove the f-string for all the pytest.skips above this line as well. Thanks.
Squashed to single commit for review. Original PR: #8 Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
andrewwhitecdw
force-pushed
the
codequality/test-fused-attn-typo-and-unnecessary-f-string-in-brcm
branch
from
August 13, 2026 16:57
473dbe3 to
7c1cbfd
Compare
Contributor
Author
|
Thanks @cyanguwa! I removed the unnecessary f-strings from the other |
cyanguwa
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo in
tests/jax/test_fused_attn.py: typo and unnecessary f-string in BRCM skip message.Changes
tests/jax/test_fused_attn.py: typo and unnecessary f-string in BRCM skip message.Details
Tests