Skip to content

fix: typo and unnecessary f-string in BRCM skip message #3370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cyanguwa merged 1 commit into from
Aug 13, 2026
+3 −3
Merged

fix: typo and unnecessary f-string in BRCM skip message #3370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/jax/test_fused_attn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,12 +476,12 @@ def _check_configs(self):
if self.attn_mask_type.is_bottom_right():
if self.max_seqlen_q > self.max_seqlen_kv:
pytest.skip(
f"BRCM requires cross attn type pattern, i.e.max_seqlen_kv >= max_seqlen_q"
"BRCM requires cross attn type pattern, i.e.max_seqlen_kv >= max_seqlen_q"
)
if self.attn_bias_type is not AttnBiasType.NO_BIAS:
pytest.skip(f"cuDNN does not support pre or post scale bias for BRCM")
pytest.skip("cuDNN does not support pre or post scale bias for BRCM")
if self.dropout_prob != 0.0:
pytest.skip(f"cuDNN does not support non-zero dropoouts for BRCM")
pytest.skip("cuDNN does not support non-zero dropouts for BRCM")

if self.qkv_layout.is_qkvpacked():
if self.max_seqlen_q != self.max_seqlen_kv:
Expand Down
Loading