Update PyTorch base container from 26.02 to 26.03#1540
Merged
pstjohn merged 1 commit intoNVIDIA:mainfrom Apr 1, 2026
Merged
Conversation
Update all Dockerfiles, CI workflows, and devcontainer to use the new PyTorch 26.03-py3 base image. Squashed image available at: docker.io/svcbionemo023/bionemo-framework:pytorch26.03-py3-squashed Refs: BIO-289 Signed-off-by: svc-bionemo <267129667+svc-bionemo@users.noreply.github.com>
svc-bionemo
requested review from
cspades,
dorotat-nv,
jomitchellnv,
jstjohn,
jwilber,
pstjohn,
savitha-eng and
trvachov
as code owners
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
yzhang123
approved these changes
Mar 31, 2026
pstjohn
approved these changes
Apr 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
…patibility (#1553) ## Problem Nightly CI has been failing for 7 consecutive days (4/11–4/17) across `models/mixtral`, `models/llama3`, `models/qwen`, and `verify-recipe-tests`. All failures share the same root cause: ``` AttributeError: 'HFInferenceParams' object has no attribute 'is_compileable' ``` The 26.03 PyTorch container update (#1540) brought `transformers==5.5.4`, which added an `is_compileable` property check on cache objects during `generate()`. The custom `HFInferenceParams` class does not implement this property. ## Fix Added `is_compileable` property returning `False` to `HFInferenceParams` in all 6 affected files (4 model sources + 2 recipe copies). The property returns `False` since this custom TE-based cache wrapper is not compatible with `torch.compile`. ## Failing CI run https://github.com/NVIDIA/bionemo-framework/actions/runs/24558420210 ## Testing - Pre-commit checks pass - `check_copied_files.py` confirms all copies are in sync - Fix is minimal and targeted (5 lines per file) Signed-off-by: svc-bionemo <svc-bionemo@nvidia.com> Signed-off-by: svc-bionemo <267129667+svc-bionemo@users.noreply.github.com> Co-authored-by: svc-bionemo <267129667+svc-bionemo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update all PyTorch base container references from
26.02-py3to26.03-py3.Squashed image available at:
docker.io/svcbionemo023/bionemo-framework:pytorch26.03-py3-squashedFiles Changed (19)
bionemo-recipes/(models + recipes).github/workflows/)Refs: BIO-289