Skip to content

Fix HFInferenceParams missing is_compileable for transformers 5.x compatibility#1553

Merged
pstjohn merged 1 commit intoNVIDIA:mainfrom
svc-bionemo:svc-bionemo/fix-nightly-20260417-e4b2d772
Apr 17, 2026
Merged

Fix HFInferenceParams missing is_compileable for transformers 5.x compatibility#1553
pstjohn merged 1 commit intoNVIDIA:mainfrom
svc-bionemo:svc-bionemo/fix-nightly-20260417-e4b2d772

Conversation

@svc-bionemo
Copy link
Copy Markdown
Collaborator

Problem

Nightly CI has been failing for 7 consecutive days (4/11–4/17) across models/mixtral, models/llama3, models/qwen, and verify-recipe-tests.

All failures share the same root cause:

AttributeError: 'HFInferenceParams' object has no attribute 'is_compileable'

The 26.03 PyTorch container update (#1540) brought transformers==5.5.4, which added an is_compileable property check on cache objects during generate(). The custom HFInferenceParams class does not implement this property.

Fix

Added is_compileable property returning False to HFInferenceParams in all 6 affected files (4 model sources + 2 recipe copies). The property returns False since this custom TE-based cache wrapper is not compatible with torch.compile.

Failing CI run

https://github.com/NVIDIA/bionemo-framework/actions/runs/24558420210

Testing

  • Pre-commit checks pass
  • check_copied_files.py confirms all copies are in sync
  • Fix is minimal and targeted (5 lines per file)

…patibility

transformers 5.5.4 (introduced via PyTorch 26.03 base container) added an
is_compileable property check on cache objects in generate(). Add is_compileable
returning False to HFInferenceParams in all model files (llama3, qwen2, qwen3,
mixtral) and their recipe copies.

Signed-off-by: svc-bionemo <svc-bionemo@nvidia.com>
Signed-off-by: svc-bionemo <267129667+svc-bionemo@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9007c9ff-b348-43b0-a214-d80790d167b6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@pstjohn pstjohn enabled auto-merge April 17, 2026 17:38
@pstjohn
Copy link
Copy Markdown
Collaborator

pstjohn commented Apr 17, 2026

Nightly CI has been failing for 7 consecutive days (4/11–4/17) across models/mixtral, models/llama3, models/qwen, and verify-recipe-tests.

that's your only job! 😠
bad 🦞

@pstjohn pstjohn added this pull request to the merge queue Apr 17, 2026
Merged via the queue into NVIDIA:main with commit 748ec4c Apr 17, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants