Fix HFInferenceParams missing is_compileable for transformers 5.x compatibility#1553
Merged
pstjohn merged 1 commit intoNVIDIA:mainfrom Apr 17, 2026
Conversation
…patibility transformers 5.5.4 (introduced via PyTorch 26.03 base container) added an is_compileable property check on cache objects in generate(). Add is_compileable returning False to HFInferenceParams in all model files (llama3, qwen2, qwen3, mixtral) and their recipe copies. Signed-off-by: svc-bionemo <svc-bionemo@nvidia.com> Signed-off-by: svc-bionemo <267129667+svc-bionemo@users.noreply.github.com>
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
pstjohn
approved these changes
Apr 17, 2026
pstjohn
approved these changes
Apr 17, 2026
Collaborator
that's your only job! 😠 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Nightly CI has been failing for 7 consecutive days (4/11–4/17) across
models/mixtral,models/llama3,models/qwen, andverify-recipe-tests.All failures share the same root cause:
The 26.03 PyTorch container update (#1540) brought
transformers==5.5.4, which added anis_compileableproperty check on cache objects duringgenerate(). The customHFInferenceParamsclass does not implement this property.Fix
Added
is_compileableproperty returningFalsetoHFInferenceParamsin all 6 affected files (4 model sources + 2 recipe copies). The property returnsFalsesince this custom TE-based cache wrapper is not compatible withtorch.compile.Failing CI run
https://github.com/NVIDIA/bionemo-framework/actions/runs/24558420210
Testing
check_copied_files.pyconfirms all copies are in sync