Remove most CCCL_GRID_CONSTANT annotations - #9858
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesCUB CUDA kernel signatures remove CUB kernel entrypoints
Possibly related PRs
Suggested reviewers: Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
cub/cub/device/dispatch/kernels/kernel_scan.cuh (1)
205-211: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valuesuggestion: The
#if _CCCL_CUDACC_AT_LEAST(12, 8)/#endifblock at Lines 206-208 is now empty — it previously guarded a_CCCL_GRID_CONSTANTannotation oninit_valuethat has been removed. Leaving a no-op conditional is confusing dead code; consider dropping the guard entirely since it no longer wraps anything.🧹 Proposed cleanup
const ScanOpT scan_op, -// nvcc 12.0 gets stuck compiling some TUs like `cub.bench.scan.exclusive.sum.base`, so only enable for newer versions -#if _CCCL_CUDACC_AT_LEAST(12, 8) - -#endif // _CCCL_CUDACC_AT_LEAST(12, 8) const InitValueT init_value,
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 525248ef-8250-440b-a044-a58937d587f4
📒 Files selected for processing (20)
cub/cub/device/dispatch/dispatch_adjacent_difference.cuhcub/cub/device/dispatch/dispatch_batch_memcpy.cuhcub/cub/device/dispatch/dispatch_merge.cuhcub/cub/device/dispatch/dispatch_reduce_by_key.cuhcub/cub/device/dispatch/dispatch_rle.cuhcub/cub/device/dispatch/dispatch_scan_by_key.cuhcub/cub/device/dispatch/dispatch_segmented_sort.cuhcub/cub/device/dispatch/dispatch_topk.cuhcub/cub/device/dispatch/kernels/kernel_for_each.cuhcub/cub/device/dispatch/kernels/kernel_histogram.cuhcub/cub/device/dispatch/kernels/kernel_radix_sort.cuhcub/cub/device/dispatch/kernels/kernel_reduce.cuhcub/cub/device/dispatch/kernels/kernel_scan.cuhcub/cub/device/dispatch/kernels/kernel_segmented_radix_sort.cuhcub/cub/device/dispatch/kernels/kernel_segmented_reduce.cuhcub/cub/device/dispatch/kernels/kernel_segmented_scan.cuhcub/cub/device/dispatch/kernels/kernel_segmented_sort.cuhcub/cub/device/dispatch/kernels/kernel_three_way_partition.cuhcub/cub/device/dispatch/kernels/kernel_transform.cuhcub/cub/device/dispatch/kernels/kernel_unique_by_key.cuh
This comment has been minimized.
This comment has been minimized.
🥳 CI Workflow Results🟩 Finished in 3h 34m: Pass: 100%/287 | Total: 6d 05h | Max: 2h 12m | Hits: 43%/525623See results here. |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin branch/3.4.x
git worktree add -d .worktree/backport-9858-to-branch/3.4.x origin/branch/3.4.x
cd .worktree/backport-9858-to-branch/3.4.x
git switch --create backport-9858-to-branch/3.4.x
git cherry-pick -x d8fd76b44b0e4de1ae6e1b4d606fe72636b10df4 |
…uding merge sort (#9864) * Remove most `CCCL_GRID_CONSTANT` annotations (#9858) QA reported several regressions caused by the introduction of `_CCCL_GRID_CONSTANT` in #6642. The regressions include: - #9763 - #9765 - #9766 - #9768 - #9822 The cause of the regression is probably a compiler bug, reported in NVBug 6448961. This PR mainly reverts #6642, but since a lot of time has passed, I needed to do a lot of manual editing as well. Fixes: #9768 Fixes: #9822 Fixes: #9851 (cherry picked from commit d8fd76b) * Remove _CCCL_GRID_CONSTANT from merge sort kernel parameters (#9829) Co-authored-by: Paul Grosse-Bley <pauleonix-dev@pm.me> --------- Co-authored-by: nanan-nvidia <nan@nvidia.com> Co-authored-by: Paul Grosse-Bley <pauleonix-dev@pm.me>
QA reported several regressions caused by the introduction of
_CCCL_GRID_CONSTANTin #6642. The regressions include:select_flaggedregresses in CCCL 3.4 on H100 #9763select_ifregresses in CCCL 3.4 #9765select_uniqueregresses in CCCL 3.4 on Blackwell and Ampere #9766radix_sort_keysregresses in CCCL 3.4 #9768reduce_by_keyregressed in CCCL 3.4 on Blackwell, Hopper and Ada #9822The cause of the regression is probably a compiler bug, reported in NVBug 6448961. When the fix is available, we will be able to bring the
_CCCL_GRID_CONSTANTannotations back, but this time after carefully benchmarking their impact :)This PR mainly reverts #6642, but since a lot of time has passed, I needed to do a lot of manual editing as well.
This PR supersedes:
_CCCL_GRID_CONSTANTfromDeviceReduce::ReduceByKeykernels #9852_CCCL_GRID_CONSTANTfrom scan kernel #9854Previous PRs removing annotations:
_CCCL_GRID_CONSTANTfromDeviceSelectSweepKernelparameters #9795This PR will not remove annotations from these kernels, because they have not been added by #6642 and QA did not report any regressions:
device_partition_find_bound_sorted_values_kerneldevice_find_bound_sorted_values_kernel__copy_contiguous_kernel__copy_optimized_kernel__copy_shared_mem_kernelloop(inparallel_for_scope.cuhin STF)__kernel_launcher_with_block_size(part ofcuda::launch)benchmark_kernel(part of nvbench_helper)Fixes: #9768
Fixes: #9822
Fixes: #9851