[Backport to 3.4] Remove most _CCCL_GRID_CONSTANT annotations, including merge sort - #9864
Merged
wmaxey merged 2 commits intoJul 14, 2026
Merged
Conversation
QA reported several regressions caused by the introduction of `_CCCL_GRID_CONSTANT` in NVIDIA#6642. The regressions include: - NVIDIA#9763 - NVIDIA#9765 - NVIDIA#9766 - NVIDIA#9768 - NVIDIA#9822 The cause of the regression is probably a compiler bug, reported in NVBug 6448961. This PR mainly reverts NVIDIA#6642, but since a lot of time has passed, I needed to do a lot of manual editing as well. Fixes: NVIDIA#9768 Fixes: NVIDIA#9822 Fixes: NVIDIA#9851 (cherry picked from commit d8fd76b)
…9829) Co-authored-by: Paul Grosse-Bley <pauleonix-dev@pm.me>
_CCCL_GRID_CONSTANT annotations, including merge sort
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (21)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesThe PR removes CUB kernel signature updates
Possibly related PRs
Suggested labels: Suggested reviewers: Comment |
NaderAlAwar
approved these changes
Jul 14, 2026
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 24m: Pass: 100%/283 | Total: 11d 22h | Max: 2h 24m | Hits: 15%/1080970See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports the following two PRs:
CCCL_GRID_CONSTANTannotations #9858 (cherry-picked from d8fd76b)