Skip to content

Include <optional> for GCC 11 compatibility. - #10927

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-22.08from
bdice:fix/include-optional-generate-input
May 24, 2022
Merged

Include <optional> for GCC 11 compatibility.#10927
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-22.08from
bdice:fix/include-optional-generate-input

Conversation

@bdice

@bdice bdice commented May 23, 2022

Copy link
Copy Markdown
Contributor

This PR fixes a missing include in generate_input.hpp that prevents benchmarks from building with GCC 11.

@bdice
bdice requested a review from a team as a code owner May 23, 2022 16:43
@bdice
bdice requested review from hyperbolic2346 and ttnghia May 23, 2022 16:43
@bdice bdice self-assigned this May 23, 2022
@github-actions github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label May 23, 2022
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 23, 2022
@bdice

bdice commented May 23, 2022

Copy link
Copy Markdown
Contributor Author

rerun tests

@codecov

codecov Bot commented May 23, 2022

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@9e4fc74). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5191f3c differs from pull request most recent head 0b13680. Consider uploading reports for the commit 0b13680 to get more accurate results

@@               Coverage Diff               @@
##             branch-22.08   #10927   +/-   ##
===============================================
  Coverage                ?   86.30%           
===============================================
  Files                   ?      144           
  Lines                   ?    22668           
  Branches                ?        0           
===============================================
  Hits                    ?    19563           
  Misses                  ?     3105           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4fc74...0b13680. Read the comment docs.

@bdice

bdice commented May 24, 2022

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 9b18987 into NVIDIA:branch-22.08 May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants