Fix bug with row count comparison for expect_columns_equivalent(). - #11059
Merged
rapids-bot[bot] merged 2 commits intoJun 15, 2022
Merged
Conversation
nvdbaranec
added
bug
vuule
approved these changes
Jun 6, 2022
ttnghia
approved these changes
Jun 6, 2022
ttnghia
left a comment
ttnghia
left a comment
Contributor
There was a problem hiding this comment.
If you can add const after auto then it's perfect to me.
hyperbolic2346
approved these changes
Jun 6, 2022
vyasr
approved these changes
Jun 7, 2022
Contributor
|
rerun tests |
Contributor
Author
|
I'm out until Monday, so let's hold off on merging this until then :) |
Contributor
Author
|
rerun tests |
1 similar comment
Contributor
Author
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11059 +/- ##
===============================================
Coverage ? 86.34%
===============================================
Files ? 144
Lines ? 22738
Branches ? 0
===============================================
Hits ? 19632
Misses ? 3106
Partials ? 0 Continue to review full report at Codecov.
|
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Top level row counts were being compared incorrectly for the
_equivalent()check. No tests were affected by this, thankfully. In addition, even though_equal()was correct, I made the same modification to the call (passing separate index lists for the two columns) to future-proof against internal changes to the comparison function.