Add npos const static member to cudf::string_view - #11166
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11166 +/- ##
===============================================
Coverage ? 86.30%
===============================================
Files ? 144
Lines ? 22698
Branches ? 0
===============================================
Hits ? 19589
Misses ? 3109
Partials ? 0 Continue to review full report at Codecov.
|
davidwendt
marked this pull request as ready for review
July 6, 2022 18:12
bdice
approved these changes
Jul 6, 2022
bdice
left a comment
Contributor
There was a problem hiding this comment.
Approving with small questions/comments.
ttnghia
reviewed
Jul 7, 2022
ttnghia
approved these changes
Jul 7, 2022
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
nposmember tocudf::string_viewfor consistency withstd::string_view::nposhttps://en.cppreference.com/w/cpp/string/basic_string_view/nposThis is used mainly in the
find()andrfind()functions which should returnnposwhen the target string is not found. Code updates are included in this PR to usenposinstead. This change will help when building and documenting strings-udf functions that usefind()andrfind().Also moved
UNKNOWN_STRING_LENGTHinto thestring_viewclass scope since it is only used internally bystring_view.No actual code behavior has changed.