Generate benchmark data with correct run length regardless of cardinality - #11205
Merged
rapids-bot[bot] merged 2 commits intoJul 7, 2022
Merged
Conversation
vuule
added
bug
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11205 +/- ##
===============================================
Coverage ? 86.30%
===============================================
Files ? 144
Lines ? 22698
Branches ? 0
===============================================
Hits ? 19589
Misses ? 3109
Partials ? 0 Continue to review full report at Codecov.
|
davidwendt
reviewed
Jul 7, 2022
Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
davidwendt
approved these changes
Jul 7, 2022
davidwendt
approved these changes
Jul 7, 2022
ttnghia
approved these changes
Jul 7, 2022
nvdbaranec
approved these changes
Jul 7, 2022
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #11204
The new GPU-accelerated data generator does not account for run length when cardinality is not set.
This PR changes the logic so that the columns with correct average run length are generated even without specific cardinality.