Avoid using nvcompBatchedDeflateDecompressGetTempSizeEx in cuIO - #11213
Merged
rapids-bot[bot] merged 2 commits intoJul 8, 2022
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11213 +/- ##
===============================================
Coverage ? 86.30%
===============================================
Files ? 144
Lines ? 22698
Branches ? 0
===============================================
Hits ? 19589
Misses ? 3109
Partials ? 0 Continue to review full report at Codecov.
|
jbrennan333
approved these changes
Jul 7, 2022
jbrennan333
left a comment
jbrennan333
left a comment
Contributor
There was a problem hiding this comment.
+1 this looks good to me. I have applied this patch and verified that python can import cudf with the original (broken) nvcomp-2.3.2 library and also with the new fixed one.
vyasr
reviewed
Jul 7, 2022
hyperbolic2346
approved these changes
Jul 7, 2022
vyasr
approved these changes
Jul 7, 2022
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed due to an issue in nvCOMP 2.3.1 and 2.3.2.
nvCOMP integration falls back to
nvcompBatchedDeflateDecompressGetTempSizewhen GetTempSizeEx is not available and for DEFLATE. Once DEFLATE issue is fixed, we'll condition GetTempSizeEx use on the nvCOMP version.