Treat zstd as stable in nvcomp releases 2.3.2 and later - #11226
Merged
rapids-bot[bot] merged 2 commits intoJul 11, 2022
Conversation
jbrennan333
added
feature request
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11226 +/- ##
===============================================
Coverage ? 86.30%
===============================================
Files ? 144
Lines ? 22698
Branches ? 0
===============================================
Hits ? 19589
Misses ? 3109
Partials ? 0 Continue to review full report at Codecov.
|
PointKernel
approved these changes
Jul 8, 2022
PointKernel
left a comment
PointKernel
left a comment
Member
There was a problem hiding this comment.
One non-blocking suggestion. LGTM
ttnghia
approved these changes
Jul 8, 2022
Member
|
@gpucibot merge |
Contributor
Author
|
Thanks for the reviews and merge! |
vyasr
added
4 - Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on our testing of nvcomp zstd decompression with the spark-rapids plugin, we believe that ZSTD should be treated as stable starting with nvcomp release 2.3.2.
Specifically, one should no longer need to specify LIBCUDF_NVCOMP_POLICY=ALWAYS to use ZSTD in cuDF. Note that currently cuDF is still using nvcomp-2.3.0, which should still be treated as experimental.