Skip to content

Switch death test to use explicit trap. - #11326

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-22.08from
vyasr:fix/death_test
Jul 21, 2022
Merged

Switch death test to use explicit trap.#11326
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-22.08from
vyasr:fix/death_test

Conversation

@vyasr

@vyasr vyasr commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

This change should make the test fail reliably, whereas the current approach is flaky and leads to not infrequent test failures.

@vyasr vyasr added 3 - Ready for Review Ready for review by team tests Unit testing for project libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 21, 2022
@vyasr
vyasr requested a review from a team as a code owner July 21, 2022 21:03
@vyasr vyasr self-assigned this Jul 21, 2022
@vyasr
vyasr requested review from bdice and devavret July 21, 2022 21:03
@codecov

codecov Bot commented Jul 21, 2022

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@406bce7). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08   #11326   +/-   ##
===============================================
  Coverage                ?   86.40%           
===============================================
  Files                   ?      143           
  Lines                   ?    22753           
  Branches                ?        0           
===============================================
  Hits                    ?    19659           
  Misses                  ?     3094           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 406bce7...74530d0. Read the comment docs.

@bdice

bdice commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 719f4c8 into NVIDIA:branch-22.08 Jul 21, 2022
@vyasr
vyasr deleted the fix/death_test branch July 21, 2022 23:19
rapids-bot Bot pushed a commit that referenced this pull request Jul 25, 2022
This PR follows up on #11149 to add the lists filtering (stream compaction) APIs to a doxygen group. The previous doxygen group `lists_drop_duplicates` is empty after #11326.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - David Wendt (https://github.com/davidwendt)
  - Vukasin Milovanovic (https://github.com/vuule)

URL: #11336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change tests Unit testing for project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants