Determine if Arrow has S3 support at runtime in unit test. - #11560
Conversation
Codecov ReportBase: 88.11% // Head: 88.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11560 +/- ##
================================================
+ Coverage 88.11% 88.14% +0.03%
================================================
Files 133 133
Lines 21982 21982
================================================
+ Hits 19369 19376 +7
+ Misses 2613 2606 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This PR has been labeled |
No, we don't have a way to test the configuration with S3 disabled in CI. We would have to make significant changes to how dependencies are installed in CI. It might be possible once CI is more configurable via a GitHub Actions matrix build, but I don't think the benefit is worth the cost here. |
|
@gpucibot merge |
Description
Resolves #11559. This PR improves the logic for testing S3 support. Previously this test relied on the value of
CUDF_ENABLE_ARROW_S3, which only enables S3 support in Arrow if Arrow is being built from source by libcudf. If the Arrow package is found locally (rather than fetched and built), the value ofCUDF_ENABLE_ARROW_S3was irrelevant. Therefore, the tests using the compile-time value ofCUDF_ENABLE_ARROW_S3were unable to correctly detect Arrow's S3 support. This PR fixes the problem by checking Arrow S3 support at runtime.I tested this locally for the case where Arrow doesn't have S3 support (our CI uses prebuilt Arrow packages with S3 enabled).
Checklist