Skip to content

Use public APIs in STREAM_COMPACTION_NVBENCH - #11892

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-22.12from
GregoryKimball:use-public-api-in-stream_compaction_nvbench
Oct 11, 2022
Merged

Use public APIs in STREAM_COMPACTION_NVBENCH#11892
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-22.12from
GregoryKimball:use-public-api-in-stream_compaction_nvbench

Conversation

@GregoryKimball

Copy link
Copy Markdown
Contributor

Description

Use state.set_cuda_stream to set the stream for the nvbench benchmark. Then run state.exec on the public API instead of the detail API, e.g. cudf::distinct instead of cudf::detail::distinct.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@GregoryKimball
GregoryKimball requested a review from a team as a code owner October 11, 2022 03:49
@github-actions github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label Oct 11, 2022
@GregoryKimball GregoryKimball added tech debt non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Oct 11, 2022
@codecov

codecov Bot commented Oct 11, 2022

Copy link
Copy Markdown

Codecov Report

Base: 87.40% // Head: 87.48% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (2733bc6) compared to base (f72c4ce).
Patch coverage: 84.03% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11892      +/-   ##
================================================
+ Coverage         87.40%   87.48%   +0.07%     
================================================
  Files               133      133              
  Lines             21833    21864      +31     
================================================
+ Hits              19084    19128      +44     
+ Misses             2749     2736      -13     
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/__init__.py 50.00% <ø> (ø)
python/cudf/cudf/io/orc.py 92.94% <ø> (-0.09%) ⬇️
python/cudf/cudf/utils/ioutils.py 79.47% <ø> (ø)
...thon/dask_cudf/dask_cudf/tests/test_distributed.py 18.86% <ø> (+4.94%) ⬆️
python/cudf/cudf/core/_base_index.py 82.20% <43.75%> (-3.35%) ⬇️
python/cudf/cudf/io/text.py 91.66% <66.66%> (-8.34%) ⬇️
python/strings_udf/strings_udf/__init__.py 86.27% <76.00%> (-10.61%) ⬇️
python/cudf/cudf/core/index.py 92.91% <95.08%> (+0.27%) ⬆️
python/cudf/cudf/__init__.py 90.69% <100.00%> (ø)
python/cudf/cudf/core/column/categorical.py 89.34% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@karthikeyann karthikeyann left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@GregoryKimball

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 9ba6142 into NVIDIA:branch-22.12 Oct 11, 2022
@GregoryKimball
GregoryKimball deleted the use-public-api-in-stream_compaction_nvbench branch October 11, 2022 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants