Pin mimesis version in setup.py. - #11906
Conversation
|
Opened rapidsai/integration#548 to unblock tests. |
Looks like @bdice already opened a PR: rapidsai/integration#547 |
|
Didn't see that :) Closed mine. |
|
rerun tests |
2 similar comments
|
rerun tests |
|
rerun tests |
Codecov ReportBase: 87.40% // Head: 88.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11906 +/- ##
================================================
+ Coverage 87.40% 88.13% +0.72%
================================================
Files 133 133
Lines 21833 21905 +72
================================================
+ Hits 19084 19305 +221
+ Misses 2749 2600 -149
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ajschmidt8
left a comment
There was a problem hiding this comment.
Approving ops-codeowner file changes
|
@gpucibot merge |
1 similar comment
|
@gpucibot merge |
Description
The dependency pinning for
mimesisin cudf'ssetup.pydidn't match the conda environment. It was missing a pinning to<4.1from #8745. However, based on the conversation in #8551, this pinning of<4.1was only chosen because 4.1.0 wasn't yet available on conda-forge. Since the current version of mimesis is now 6.1.1, this PR updates the mimesis pinning to>=4.1and usesgenerate_stringinstead ofschoice. I tested this locally with mimesis 6.1.1 and mimesis 4.1.0 and both passed tests.Merge this PR concurrently with rapidsai/integration#547.
Checklist