Pin mimesis to <12 - #14720
Closed
mroeschke wants to merge 1 commit into
Closed
Conversation
bdice
approved these changes
Jan 8, 2024
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
FYI there is a past discussion of whether we could drop mimesis as a dependency here: #13257 (review)
We've run into breaking changes from mimesis several times before: #8745, #11906, #13257. I would really like to cut this dependency as it has been one of our most problematic dependencies, especially relative to how little we use it.
karthikeyann
approved these changes
Jan 8, 2024
ajschmidt8
approved these changes
Jan 8, 2024
3 tasks
Contributor
|
Closing in favor of #14723. Thanks so much @mroeschke for the additional PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Looks like a new mimesis version is failing with type annotation usage
https://github.com/rapidsai/cudf/actions/runs/7443972107/job/20262823436
Checklist