Refactor pad/zfill functions for reuse with strings udf - #11914
Merged
rapids-bot[bot] merged 7 commits intoOct 19, 2022
Conversation
Codecov ReportBase: 87.40% // Head: 88.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #11914 +/- ##
================================================
+ Coverage 87.40% 88.12% +0.71%
================================================
Files 133 133
Lines 21833 21905 +72
================================================
+ Hits 19084 19304 +220
+ Misses 2749 2601 -148
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
davidwendt
marked this pull request as ready for review
October 13, 2022 19:39
ttnghia
reviewed
Oct 14, 2022
ttnghia
reviewed
Oct 14, 2022
ttnghia
approved these changes
Oct 14, 2022
upsj
self-requested a review
October 17, 2022 12:30
upsj
approved these changes
Oct 18, 2022
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors the main device code used for
cudf::strings::padandcudf::strings::zfillfor reuse in strings UDF pad and zfill functions. No new functions or features have been added, updated, or removed. The detail functions have been mainly just be moved to new filecpp/include/cudf/strings/detail/pad_impl.cuhChecklist