Skip to content

Add missing noexcepts to column_in_metadata methods - #11973

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-22.12from
vyasr:task/types_except
Oct 25, 2022
Merged

Add missing noexcepts to column_in_metadata methods#11973
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-22.12from
vyasr:task/types_except

Conversation

@vyasr

@vyasr vyasr commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

Description

These functions cannot throw exceptions.

Resolved #11399

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 21, 2022
@vyasr
vyasr requested a review from a team as a code owner October 21, 2022 22:17
@vyasr vyasr self-assigned this Oct 21, 2022
@vyasr
vyasr requested review from bdice and hyperbolic2346 October 21, 2022 22:17
@vyasr

vyasr commented Oct 24, 2022

Copy link
Copy Markdown
Contributor Author

rerun tests

@codecov

codecov Bot commented Oct 24, 2022

Copy link
Copy Markdown

Codecov Report

Base: 88.11% // Head: 86.89% // Decreases project coverage by -1.21% ⚠️

Coverage data is based on head (7163c83) compared to base (5c2150e).
Patch has no changes to coverable lines.

❗ Current head 7163c83 differs from pull request most recent head 3dfc65a. Consider uploading reports for the commit 3dfc65a to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #11973      +/-   ##
================================================
- Coverage         88.11%   86.89%   -1.22%     
================================================
  Files               133      133              
  Lines             21982    21982              
================================================
- Hits              19369    19101     -268     
- Misses             2613     2881     +268     
Impacted Files Coverage Δ
python/cudf/cudf/core/udf/strings_lowering.py 0.00% <0.00%> (-100.00%) ⬇️
python/cudf/cudf/core/udf/strings_typing.py 0.00% <0.00%> (-95.78%) ⬇️
python/strings_udf/strings_udf/lowering.py 0.00% <0.00%> (-84.40%) ⬇️
python/cudf/cudf/core/udf/__init__.py 50.00% <0.00%> (-47.06%) ⬇️
python/strings_udf/strings_udf/_typing.py 81.05% <0.00%> (-13.69%) ⬇️
python/cudf/cudf/core/udf/utils.py 97.00% <0.00%> (-2.00%) ⬇️
python/strings_udf/strings_udf/__init__.py 84.31% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr

vyasr commented Oct 25, 2022

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 2d89f43 into NVIDIA:branch-22.12 Oct 25, 2022
@vyasr
vyasr deleted the task/types_except branch October 25, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Methods in types.pxd should be marked except +

3 participants