Skip to content

Remove default parameters for nvtext::detail functions - #12007

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-22.12from
davidwendt:remove-nvtext-detail-def-parms
Nov 1, 2022
Merged

Remove default parameters for nvtext::detail functions#12007
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-22.12from
davidwendt:remove-nvtext-detail-def-parms

Conversation

@davidwendt

Copy link
Copy Markdown
Contributor

Description

Removes default parameters from the nvtext::detail functions. Most of these were internal default parameters which were unnecessary. The nvtext detail functions are only used within nvtext APIs.

Reference #11967

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 26, 2022
@davidwendt davidwendt self-assigned this Oct 26, 2022
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 26, 2022
@davidwendt
davidwendt marked this pull request as ready for review October 26, 2022 22:10
@davidwendt
davidwendt requested a review from a team as a code owner October 26, 2022 22:10
@codecov

codecov Bot commented Oct 31, 2022

Copy link
Copy Markdown

Codecov Report

Base: 87.40% // Head: 88.13% // Increases project coverage by +0.72% 🎉

Coverage data is based on head (d3e2d8b) compared to base (f72c4ce).
Patch has no changes to coverable lines.

❗ Current head d3e2d8b differs from pull request most recent head a152a79. Consider uploading reports for the commit a152a79 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-22.12   #12007      +/-   ##
================================================
+ Coverage         87.40%   88.13%   +0.72%     
================================================
  Files               133      133              
  Lines             21833    21982     +149     
================================================
+ Hits              19084    19373     +289     
+ Misses             2749     2609     -140     
Impacted Files Coverage Δ
python/strings_udf/strings_udf/__init__.py 86.27% <0.00%> (-10.61%) ⬇️
python/cudf/cudf/io/text.py 91.66% <0.00%> (-8.34%) ⬇️
python/cudf/cudf/core/_base_index.py 81.28% <0.00%> (-4.27%) ⬇️
python/strings_udf/strings_udf/_typing.py 94.73% <0.00%> (-1.06%) ⬇️
python/cudf/cudf/utils/utils.py 89.91% <0.00%> (-0.69%) ⬇️
python/cudf/cudf/testing/dataset_generator.py 72.83% <0.00%> (-0.42%) ⬇️
python/dask_cudf/dask_cudf/core.py 73.72% <0.00%> (-0.41%) ⬇️
python/dask_cudf/dask_cudf/backends.py 84.90% <0.00%> (-0.37%) ⬇️
python/cudf/cudf/core/dataframe.py 93.67% <0.00%> (-0.10%) ⬇️
python/cudf/cudf/io/orc.py 92.94% <0.00%> (-0.09%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@davidwendt

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 991c86b into NVIDIA:branch-22.12 Nov 1, 2022
@davidwendt
davidwendt deleted the remove-nvtext-detail-def-parms branch November 1, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants