Create an int8 column in read_csv when all elements are missing - #12110
Merged
rapids-bot[bot] merged 8 commits intoNov 15, 2022
Merged
Conversation
vuule
added
improvement
Codecov ReportBase: 87.47% // Head: 88.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12110 +/- ##
================================================
+ Coverage 87.47% 88.12% +0.64%
================================================
Files 133 135 +2
Lines 21826 22133 +307
================================================
+ Hits 19093 19504 +411
+ Misses 2733 2629 -104
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…bug-read_csv-empty=column-type
hyperbolic2346
approved these changes
Nov 10, 2022
PointKernel
reviewed
Nov 11, 2022
…bug-read_csv-empty=column-type
…uule/cudf into bug-read_csv-empty=column-type
harrism
approved these changes
Nov 14, 2022
| cudf::size_type positive_small_int_count{}; | ||
| cudf::size_type big_int_count{}; | ||
| cudf::size_type bool_count{}; | ||
| auto total_count() const |
Contributor
There was a problem hiding this comment.
Perhaps for the future -- seems like this struct would be more versatile and more easily extendible (and totals easier to calculate in a bug-free way) if you store a std::array (or similar) of counts and index it using constant names for indices. Then this line could just be a std::accumulate (or similar).
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CSV reader creates int8 columns when all elements are null. However, when all elements in a
column are missing (e.g.
namesoption includes more columns than the CSV file), CSV reader creates anint64column. Such columns take up a lot more device memory.This PR changes the behavior so that all columns with no valid elements are created as
int8.Checklist