Refactor purge_nonempty_nulls - #12111
Conversation
ttnghia
added
3 - Ready for Review
| return false; | ||
| } | ||
|
|
||
| std::unique_ptr<column> purge_nonempty_nulls(column_view const& input, |
There was a problem hiding this comment.
This is moved from the deleted file copy.cuh.
|
Rerun tests. |
bdice
left a comment
bdice
left a comment
There was a problem hiding this comment.
One minor comment on docstrings, otherwise LGTM.
Someday I'd like to see the "pass-through" version of this which accepts a column && (takes ownership) and returns the existing data when possible instead of copying.
Co-authored-by: Bradley Dice <bdice@bradleydice.com>
|
Rerun tests. |
|
Rerun tests. |
Codecov ReportBase: 87.47% // Head: 88.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #12111 +/- ##
================================================
+ Coverage 87.47% 88.15% +0.67%
================================================
Files 133 135 +2
Lines 21826 22144 +318
================================================
+ Hits 19093 19520 +427
+ Misses 2733 2624 -109
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@gpucibot merge |
ajschmidt8
left a comment
ajschmidt8
left a comment
There was a problem hiding this comment.
Approving ops-codeowner file changes
5 participants
This refactor combines the discrete interfaces of
purge_nonempty_nullsthat requirestructs/strings/lists_column_viewinput into just one interface accepting justcolumn_view. This facilitates easier usage of this function. It is also a necessary step for subsequent work in fixingstructs::superimpose_parent_nulls.cudf::detailinterface for this new API is also added.