Skip to content

Expose stream parameter in public strings APIs - #14260

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-23.12from
davidwendt:stream-strings-apis
Oct 10, 2023
Merged

Expose stream parameter in public strings APIs#14260
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-23.12from
davidwendt:stream-strings-apis

Conversation

@davidwendt

Copy link
Copy Markdown
Contributor

Description

Add stream parameter to public APIs:

  • cudf::strings::strip()
  • cudf::strings::slice_strings()
  • cudf::strings::pad()
  • cudf::strings::zfill()
  • cudf::strings::wrap()

Also cleaned up some of the doxygen comments and added stream-tests.

Reference #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 6, 2023
@davidwendt davidwendt self-assigned this Oct 6, 2023
@github-actions github-actions Bot added the CMake CMake build issue label Oct 6, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 9, 2023
@davidwendt
davidwendt marked this pull request as ready for review October 9, 2023 18:23
@davidwendt
davidwendt requested a review from a team as a code owner October 9, 2023 18:23

@vyasr vyasr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwendt

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 5039d04 into NVIDIA:branch-23.12 Oct 10, 2023
@davidwendt
davidwendt deleted the stream-strings-apis branch October 10, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants