Fix host buffer access from device function in the Parquet reader - #14328
Conversation
shrshi
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
ttnghia
left a comment
There was a problem hiding this comment.
Is there any test for the related function? If yes, how this didn't crash the test?
The use of pinned memory was hiding the issue. When using pageable memory in |
Then can we have a test with both pinned memory/pageable memory? Such as through macro definition or toggling the corresponding env variable? |
I've started working on the test and realized some problems. The env var is read only once and cached. We can't enable pageable memory use for only one test. |
|
/merge |
|
Merged to enable spark experiments; we can add tests in a separate PR. |
Description
Closes #14311
The host access becomes an issue when pageable memory is used for host side of
hostdevice_vector.This PR fixes the device lambda to use the device pointer instead.
Checklist