Skip to content

Remove null mask for zero nulls in json readers - #14451

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:branch-24.02from
karthikeyann:enh-json_nonullmask
Dec 7, 2023
Merged

Remove null mask for zero nulls in json readers#14451
rapids-bot[bot] merged 4 commits into
NVIDIA:branch-24.02from
karthikeyann:enh-json_nonullmask

Conversation

@karthikeyann

@karthikeyann karthikeyann commented Nov 19, 2023

Copy link
Copy Markdown
Contributor

Description

Closes #14366
Removes null mask for zero nulls in json readers (nested json reader and legacy json reader in gpu)

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@karthikeyann karthikeyann added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. 4 - Needs Review Waiting for reviewer to review or respond cuIO cuIO issue 4 - Needs cuIO Reviewer Performance Performance related issue improvement Improvement / enhancement to an existing function breaking Breaking change labels Nov 19, 2023
@karthikeyann karthikeyann self-assigned this Nov 19, 2023
@karthikeyann
karthikeyann marked this pull request as ready for review November 22, 2023 05:34
@karthikeyann
karthikeyann requested a review from a team as a code owner November 22, 2023 05:34
@karthikeyann karthikeyann mentioned this pull request Nov 22, 2023
Closed
@karthikeyann karthikeyann added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Nov 22, 2023
hyperbolic2346
hyperbolic2346 requested changes Dec 5, 2023
View reviewed changes

@hyperbolic2346 hyperbolic2346 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple comments

Comment thread cpp/src/io/json/nested_json_gpu.cu
Comment thread cpp/tests/io/json_test.cpp Outdated
@karthikeyann

karthikeyann commented Dec 7, 2023

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit a253826 into NVIDIA:branch-24.02 Dec 7, 2023
karthikeyann added a commit to karthikeyann/cudf that referenced this pull request Dec 12, 2023
@karthikeyann
Remove null mask for zero nulls in json readers (NVIDIA#14451)
ee0dbbe 
Closes  NVIDIA#14366
Removes null mask for zero nulls in json readers (nested json reader and legacy json reader in gpu)

Authors:
  - Karthikeyan (https://github.com/karthikeyann)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Mike Wilson (https://github.com/hyperbolic2346)

URL: NVIDIA#14451
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes
@ttnghia ttnghia ttnghia approved these changes
@nvdbaranec nvdbaranec Awaiting requested review from nvdbaranec nvdbaranec was automatically assigned from rapidsai/cudf-cpp-codeowners
@divyegala divyegala Awaiting requested review from divyegala

Assignees

@karthikeyann karthikeyann

Labels

3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond breaking Breaking change cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. Performance Performance related issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

JSON reader provides a full null mask for a column with no NULLs

4 participants

@karthikeyann @hyperbolic2346 @ttnghia @vyasr