Fix strings::contains matching end of string target - #14711
Merged
rapids-bot[bot] merged 1 commit intoJan 5, 2024
Conversation
davidwendt
added
bug
davidwendt
added
3 - Ready for Review
davidwendt
marked this pull request as ready for review
January 5, 2024 14:54
ttnghia
approved these changes
Jan 5, 2024
divyegala
approved these changes
Jan 5, 2024
bdice
approved these changes
Jan 5, 2024
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug in
cudf::strings::containswhere the target matches the end of the string. This only occurred in the long strings special kernel logic for contains.Also added additional gtests for long and short strings and for related functions find/rfind.
Closes #14710
Checklist