Skip to content

Pin pytest-cases<3.8.2 - #14756

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-24.02from
mroeschke:pin/pytest_cases
Jan 16, 2024
Merged

Pin pytest-cases<3.8.2#14756
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-24.02from
mroeschke:pin/pytest_cases

Conversation

@mroeschke

@mroeschke mroeschke commented Jan 12, 2024

Copy link
Copy Markdown
Contributor

Description

Appears in the pytest-cases 3.8.2, there's a requirement that automatically finding cases must be in a file named test_*, when historically looks like we use bench_*

https://github.com/smarie/python-pytest-cases/pull/320/files

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 12, 2024
@mroeschke
mroeschke requested review from a team as code owners January 12, 2024 23:30
@mroeschke
mroeschke requested review from shwina and wence- January 12, 2024 23:30
@github-actions github-actions Bot added the conda label Jan 12, 2024
@karthikeyann

Copy link
Copy Markdown
Contributor

/merge

1 similar comment
@ttnghia

ttnghia commented Jan 14, 2024

Copy link
Copy Markdown
Contributor

/merge

@bdice bdice mentioned this pull request Jan 16, 2024
3 tasks
@rapids-bot
rapids-bot Bot merged commit 726a7f3 into NVIDIA:branch-24.02 Jan 16, 2024
@mroeschke
mroeschke deleted the pin/pytest_cases branch January 16, 2024 15:47
@jakirkham

Copy link
Copy Markdown
Contributor

Thanks all! 🙏

rapids-bot Bot pushed a commit that referenced this pull request Jan 18, 2024
Reverts changes from #14756.

* updates `cudf`'s tests to be compatible with the latest `pytest-cases` ([version 3.8.2](https://pypi.org/project/pytest-cases/#history))
* puts a floor of `pytest-cases>=3.8.2` on that project to be sure older versions aren't used

Authors:
  - James Lamb (https://github.com/jameslamb)

Approvers:
  - Matthew Roeschke (https://github.com/mroeschke)
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Ray Douglass (https://github.com/raydouglass)

URL: #14764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants