Rework cudf::replace_nulls to use strings::detail::copy_if_else - #15286
Merged
Conversation
ttnghia
approved these changes
Mar 20, 2024
Contributor
|
Can you post some benchmark number comparing before vs after this change please? |
Contributor
Author
|
Performance benchmark for this change. This result is mainly from the gather logic now. |
bdice
approved these changes
Apr 1, 2024
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the specialized kernels for strings in
cudf::replace_nullsand replaces them with a call tocudf::strings::detail::copy_if_elsewhich is already enabled with offsetalator support and optimized for long strings.This will also allow
cudf::replace_nullsto use large strings with no further changes.Also includes a
replace_nullsbenchmark for strings.Checklist