Skip to content

Test static builds in CI and fix nanoarrow configure - #15437

Merged
rapids-bot[bot] merged 17 commits into
NVIDIA:branch-24.06from
vyasr:fix/nanoarrow_static_build
Apr 2, 2024
Merged

Test static builds in CI and fix nanoarrow configure#15437
rapids-bot[bot] merged 17 commits into
NVIDIA:branch-24.06from
vyasr:fix/nanoarrow_static_build

Conversation

@vyasr

@vyasr vyasr commented Apr 2, 2024

Copy link
Copy Markdown
Collaborator

Description

Resolves #15275
Resolves #15434

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr self-assigned this Apr 2, 2024
@github-actions github-actions Bot added the ci label Apr 2, 2024
@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change and removed ci labels Apr 2, 2024
@vyasr
vyasr force-pushed the fix/nanoarrow_static_build branch from 5009a99 to a554f1f Compare April 2, 2024 16:39
@github-actions github-actions Bot added the ci label Apr 2, 2024
@github-actions github-actions Bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Apr 2, 2024
@vyasr
vyasr marked this pull request as ready for review April 2, 2024 17:31
@vyasr
vyasr requested review from a team as code owners April 2, 2024 17:31
Comment thread .github/workflows/pr.yaml
Comment thread ci/configure_cpp_static.sh Outdated
Comment thread ci/configure_cpp_static.sh
Comment thread cpp/cmake/thirdparty/get_nanoarrow.cmake
@vyasr
vyasr requested a review from bdice April 2, 2024 21:17
@ttnghia

ttnghia commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit 2584fd9 into NVIDIA:branch-24.06 Apr 2, 2024
@vyasr
vyasr deleted the fix/nanoarrow_static_build branch April 2, 2024 23:44
@jlowe

jlowe commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

This fix allows our spark-rapids-jni builds to progress past the libcudf configure and successfully build and install libcudf. However once we try to use the installed libcudf, it fails with another nanoarrow issue. See #15453.

rapids-bot Bot pushed a commit that referenced this pull request Apr 16, 2024
The new `configure_cpp_static.sh` script added in #15437 is calling `rapids-configure-conda-channels`. However, it is doing so on a `ci-wheel` image, which fails. This is causing CI issues and needs to be removed.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #15539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

6 participants