Drop Centos7 support - #15608
Merged
Merged
Conversation
To fix NVIDIA#15583 Change to run build in Rocky8 docker container Signed-off-by: Tim Liu <timl@nvidia.com>
NvTimLiu
added
ci
breaking
jlowe
approved these changes
Apr 29, 2024
jlowe
left a comment
jlowe
left a comment
Contributor
There was a problem hiding this comment.
Minor nits otherwise lgtm.
Signed-off-by: Tim Liu <timl@nvidia.com>
bdice
reviewed
Apr 29, 2024
bdice
left a comment
bdice
left a comment
Contributor
There was a problem hiding this comment.
One typo -- otherwise LGTM.
bdice
reviewed
Apr 29, 2024
Co-authored-by: Bradley Dice <bdice@bradleydice.com> Co-authored-by: Jason Lowe <jlowe@nvidia.com>
Signed-off-by: Tim Liu <timl@nvidia.com>
bdice
approved these changes
Apr 29, 2024
24 tasks
Contributor
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
@rapidsai/ops-codeowners can you help review? Thanks! |
Contributor
|
I merged the upstream and resolved a merge conflict from #15619. I also pinged ops for a review, after which this should be ready to merge. |
raydouglass
reviewed
May 2, 2024
raydouglass
left a comment
raydouglass
left a comment
Contributor
There was a problem hiding this comment.
Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.
raydouglass
approved these changes
May 2, 2024
raydouglass
left a comment
raydouglass
left a comment
Contributor
There was a problem hiding this comment.
Did it out of order, so approved to remove any blockers.
Contributor
|
/okay to test |
Contributor
|
Thanks @NvTimLiu! |
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix #15583
We plan to drop CentOS 7 (which uses glibc 2.17) RAPIDS 24.06. The java/ci/Dockerfile.centos7, refor or to :
https://docs.rapids.ai/notices/rsn0037/
rapidsai/build-planning#23
Change to run build in Rocky8 docker container
Checklist