Apply primitive row operators into hash join - #18896
Merged
rapids-bot[bot] merged 47 commits intoJun 18, 2025
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
3 tasks
rapids-bot Bot
pushed a commit
that referenced
this pull request
May 22, 2025
…on (#18925) Discovered while working on #18896, this PR adds `#pragma once` directives to eliminate redundant header inclusions and reduce compilation time. Authors: - Yunsong Wang (https://github.com/PointKernel) - Bradley Dice (https://github.com/bdice) Approvers: - David Wendt (https://github.com/davidwendt) - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) URL: #18925
Member
Author
|
/ok to test |
Member
Author
|
/ok to test |
Member
Author
|
I’ve updated the PR to include only the hash join changes. @davidwendt @bdice could you please take another look? |
bdice
approved these changes
Jun 17, 2025
bdice
left a comment
Contributor
There was a problem hiding this comment.
One question about detail, otherwise LGTM.
mhaseeb123
reviewed
Jun 17, 2025
mhaseeb123
approved these changes
Jun 17, 2025
mhaseeb123
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just a couple comments at some branched paths would be appreciated.
mhaseeb123
approved these changes
Jun 17, 2025
Co-authored-by: Muhammad Haseeb <14217455+mhaseeb123@users.noreply.github.com>
davidwendt
reviewed
Jun 18, 2025
davidwendt
reviewed
Jun 18, 2025
Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
davidwendt
reviewed
Jun 18, 2025
davidwendt
approved these changes
Jun 18, 2025
Member
Author
|
/merge |
3 tasks
Contributor
|
Benchmark numbers on H100 |
3 tasks
This was referenced Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #15700
This PR updates hash join to leverage primitive row operators where applicable, resulting in performance improvements of 10% to 30%.
Checklist