Use radix sort for all fixed-width-types in cudf::sort - #19208
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
Performance improvement similar to those for |
bdice
left a comment
There was a problem hiding this comment.
Really nice, so glad to see this. No concerns from my side aside from naming. I'd like everything labeled "faster sort" to be labeled as "radix sort" or a variation thereof. I think it's a lot clearer to readers.
There was a problem hiding this comment.
Maybe we can rename this and related files to radix_sort or sort_radix? I think the word "faster" isn't especially helpful to readers.
There was a problem hiding this comment.
Ok. I'm working on one more follow on PR for this and I'm trying not to collide the names too much.
I like sort_radix too. Mainly because it puts the file closer alphabetically to the other sort source files otherwise the rank files get in between them.
|
This is cool. I'm impressed at how much faster the radix sort path is even with the extra materialization to initialize the |
mhaseeb123
left a comment
There was a problem hiding this comment.
LGTM. Some minor comments
| src/sort/sort_column.cu | ||
| src/sort/sort_radix.cu |
There was a problem hiding this comment.
This makes me think that alongside with column and table now we have some "radix" data structure to sort 😃
|
/merge |
Description
Refactors internal dispatch function to use cub radix sort for all fixed-width types in
cudf::sortAlso adds a benchmark for
cudf::sortChecklist