Skip to content

Move ast expression function definitions to .cpp files - #19250

Merged
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-25.08from
davidwendt:ast-exp-defs
Jul 8, 2025
Merged

Move ast expression function definitions to .cpp files#19250
rapids-bot[bot] merged 2 commits into
NVIDIA:branch-25.08from
davidwendt:ast-exp-defs

Conversation

@davidwendt

Copy link
Copy Markdown
Contributor

Description

Moving some of the ast expression function definitions from the .hpp files to .cpp files.
These headers are included in many of our slower compiling source files.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt self-assigned this Jun 30, 2025
@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 30, 2025
@copy-pr-bot

copy-pr-bot Bot commented Jun 30, 2025

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@davidwendt

Copy link
Copy Markdown
Contributor Author

/ok to test

@davidwendt

Copy link
Copy Markdown
Contributor Author

/ok to test

@davidwendt davidwendt changed the title (experimental) Move ast expression function definitions to .cpp files Move ast expression function definitions to .cpp files Jul 3, 2025
@davidwendt
davidwendt marked this pull request as ready for review July 3, 2025 20:44
@davidwendt
davidwendt requested a review from a team as a code owner July 3, 2025 20:44
@davidwendt
davidwendt requested review from devavret and nvdbaranec July 3, 2025 20:44
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Jul 3, 2025
@davidwendt

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 0b6e9ba into NVIDIA:branch-25.08 Jul 8, 2025
177 of 178 checks passed
@davidwendt
davidwendt deleted the ast-exp-defs branch July 8, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants