Include thrust::pair headers - #20708
Merged
Merged
Conversation
bdice
added
improvement
ttnghia
approved these changes
Nov 22, 2025
Contributor
|
Should we move to |
Contributor
Author
|
@davidwendt Yes, we do want that soon-ish. In the immediate term I want to eliminate as many hard errors as I can with minimal potential downsides, because the CCCL 3.2 build logs are unintelligible right now with so many errors. Having these headers is a starting point for the larger refactor to non-deprecated types. |
davidwendt
approved these changes
Nov 22, 2025
Contributor
Author
|
/merge |
TomAugspurger
pushed a commit
to TomAugspurger/pygdf
that referenced
this pull request
Nov 26, 2025
We need to include `<thrust/pair.h>` wherever `thrust::pair<T>` is used. This is needed to eliminate some errors with CCCL 3.2. Authors: - Bradley Dice (https://github.com/bdice) - David Wendt (https://github.com/davidwendt) Approvers: - Nghia Truong (https://github.com/ttnghia) - David Wendt (https://github.com/davidwendt) URL: NVIDIA#20708
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need to include
<thrust/pair.h>whereverthrust::pair<T>is used. This is needed to eliminate some errors with CCCL 3.2.Checklist