Use public gather in libcudf benchmarks and gtests - #21903
Merged
Conversation
davidwendt
added
2 - In Progress
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
davidwendt
added
3 - Ready for Review
davidwendt
marked this pull request as ready for review
March 24, 2026 18:27
mhaseeb123
reviewed
Mar 30, 2026
ttnghia
reviewed
Mar 30, 2026
ttnghia
reviewed
Mar 30, 2026
davidwendt
requested review from
mhaseeb123 and
shrshi
and removed request for
a team and
AyodeAwe
March 31, 2026 18:37
shrshi
approved these changes
Mar 31, 2026
mhaseeb123
approved these changes
Mar 31, 2026
Contributor
|
@davidwendt what was the cause of the bug (failures on rtxpro6000) that you were chasing yesterday? |
Contributor
The error lies in a CUB exclusive scan call in the FST code path. A CCCL bug report has been opened to address this NVIDIA/cccl#8242 |
Contributor
Author
|
/merge |
shrshi
pushed a commit
to shrshi/cudf
that referenced
this pull request
May 12, 2026
Changes calls to `cudf::detail::gather` to equivalent public `cudf::gather` in libcudf benchmarks and gtests. Follow on to NVIDIA#21739 Authors: - David Wendt (https://github.com/davidwendt) Approvers: - Tianyu Liu (https://github.com/kingcrimsontianyu) - Shruti Shivakumar (https://github.com/shrshi) - Muhammad Haseeb (https://github.com/mhaseeb123) URL: NVIDIA#21903
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes calls to
cudf::detail::gatherto equivalent publiccudf::gatherin libcudf benchmarks and gtests.Follow on to #21739
Checklist