Improve url_decode performance for long strings - #7353
Merged
Conversation
jlowe
added
libcudf
Contributor
Author
|
Using the benchmark, here are the before and after performance numbers on a V100. The two numbers varying in the benchmark name are the number of rows and characters per row, respectively. After: |
davidwendt
self-requested a review
February 9, 2021 19:21
davidwendt
requested changes
Feb 9, 2021
davidwendt
left a comment
davidwendt
left a comment
Contributor
There was a problem hiding this comment.
This looks like a good solution. I don't think it is handling sliced columns correctly though.
vuule
requested changes
Feb 9, 2021
vuule
left a comment
vuule
left a comment
Contributor
There was a problem hiding this comment.
Few minor comments. Will take another look once the sliced input tests are in place.
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7353 +/- ##
==============================================
Coverage ? 82.22%
==============================================
Files ? 100
Lines ? 16969
Branches ? 0
==============================================
Hits ? 13953
Misses ? 3016
Partials ? 0 Continue to review full report at Codecov.
|
Contributor
Author
|
Thanks a ton for the quick reviews! I have yet to address the excellent feedback, but I wanted to post a slightly modified version of the algorithm that I found was significantly faster in practice to see if there was any suggestions/feedback on the approach. Rather than perform the expensive binary search from each character index three times (during This bears out in the new performance numbers. I added a 50% chance version of an escape sequence to compare as the number of escape sequences becomes significantly more common. |
davidwendt
requested changes
Feb 10, 2021
davidwendt
requested changes
Feb 11, 2021
vuule
requested changes
Feb 11, 2021
vuule
left a comment
vuule
left a comment
Contributor
There was a problem hiding this comment.
looks great. Just a couple of very minor comments.
vuule
approved these changes
Feb 11, 2021
davidwendt
approved these changes
Feb 11, 2021
Contributor
|
@gpucibot merge |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7348.
This changes the
url_decodealgorithm from row-level parallelism to character-level parallelism which improves the performance when operating on string columns that have longer average string lengths. A benchmark forurl_decodehas also been added.