Add string conversion to/from decimal values libcudf APIs - #7364
Merged
rapids-bot[bot] merged 25 commits intoFeb 19, 2021
Conversation
davidwendt
added
feature request
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7364 +/- ##
==============================================
Coverage ? 82.23%
==============================================
Files ? 101
Lines ? 17060
Branches ? 0
==============================================
Hits ? 14029
Misses ? 3031
Partials ? 0 Continue to review full report at Codecov.
|
ajschmidt8
approved these changes
Feb 16, 2021
nvdbaranec
suggested changes
Feb 16, 2021
nvdbaranec
approved these changes
Feb 16, 2021
harrism
requested changes
Feb 17, 2021
harrism
left a comment
harrism
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just doc questions / suggestions.
codereport
suggested changes
Feb 17, 2021
harrism
approved these changes
Feb 17, 2021
harrism
left a comment
harrism
left a comment
Contributor
There was a problem hiding this comment.
Approve, but one small comment.
codereport
suggested changes
Feb 18, 2021
codereport
left a comment
codereport
left a comment
Contributor
There was a problem hiding this comment.
so far looks good, some unit test enhancements
Contributor
Author
|
rerun tests |
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference #7285
Closes #5818
This PR adds the libcudf APIs for converting to/from decimal32 and decimal64 column types.
PR also includes
cudf::strings::is_fixed_pointcheck APIWhile coding this, I found a bug in the
fixed_point::string()operator and fixed it in this PR as well.A follow on PR will include the Python/Cython interface to the new APIs.