Skip to content

Add gbenchmark for strings split/split_record functions - #7427

Merged
rapids-bot[bot] merged 3 commits into
NVIDIA:branch-0.19from
davidwendt:benchmark-strings-split
Feb 26, 2021
Merged

Add gbenchmark for strings split/split_record functions#7427
rapids-bot[bot] merged 3 commits into
NVIDIA:branch-0.19from
davidwendt:benchmark-strings-split

Conversation

@davidwendt

Copy link
Copy Markdown
Contributor

Reference #5698
This creates a gbenchmark for the cudf::strings::split and cudf::strings::split_record functions.

This PR also includes changes to split.cu to use device_uvector for temporary buffers instead of device_vector and other minor code cleanup like adding more const decls.

@davidwendt
davidwendt requested review from a team as code owners February 23, 2021 16:55
@davidwendt davidwendt self-assigned this Feb 23, 2021
@github-actions github-actions Bot added CMake CMake build issue libcudf Affects libcudf (C++/CUDA) code. labels Feb 23, 2021
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change strings strings issues (C++ and Python) and removed CMake CMake build issue labels Feb 23, 2021

@kkraus14 kkraus14 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake lgtm

@codecov

codecov Bot commented Feb 23, 2021

Copy link
Copy Markdown

Codecov Report

Merging #7427 (7551d90) into branch-0.19 (43b44e1) will increase coverage by 0.43%.
The diff coverage is 96.66%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7427      +/-   ##
===============================================
+ Coverage        81.80%   82.24%   +0.43%     
===============================================
  Files              101      101              
  Lines            16695    17069     +374     
===============================================
+ Hits             13658    14039     +381     
+ Misses            3037     3030       -7     
Impacted Files Coverage Δ
python/cudf/cudf/core/frame.py 89.35% <ø> (+0.09%) ⬆️
python/cudf/cudf/core/column_accessor.py 95.47% <95.65%> (+2.53%) ⬆️
python/cudf/cudf/core/dataframe.py 90.58% <100.00%> (+0.12%) ⬆️
python/cudf/cudf/utils/gpu_utils.py 53.65% <0.00%> (-4.88%) ⬇️
python/cudf/cudf/core/abc.py 87.23% <0.00%> (-1.14%) ⬇️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/core/column/struct.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b44e1...30f4159. Read the comment docs.

@github-actions github-actions Bot added the CMake CMake build issue label Feb 25, 2021

@trxcllnt trxcllnt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for device_uvector

@davidwendt

Copy link
Copy Markdown
Contributor Author

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 99f0b03 into NVIDIA:branch-0.19 Feb 26, 2021
@davidwendt
davidwendt deleted the benchmark-strings-split branch February 26, 2021 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants