Skip to content

Add gbenchmarks for strings replace regex functions - #7541

Merged
rapids-bot[bot] merged 9 commits into
NVIDIA:branch-0.19from
davidwendt:benchmark-strings-replace-re
Mar 23, 2021
Merged

Add gbenchmarks for strings replace regex functions#7541
rapids-bot[bot] merged 9 commits into
NVIDIA:branch-0.19from
davidwendt:benchmark-strings-replace-re

Conversation

@davidwendt

Copy link
Copy Markdown
Contributor

Reference #5698
This creates a gbenchmark for cudf::strings::replace_re functions and the cudf::strings::replace_with_backrefs function. The benchmarks measures various sized rows as well as strings lengths. This PR also includes changes to source files for these 3 functions cleaning up the code and replacing device_vector usages with device_uvector and device_span.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 9, 2021
@davidwendt davidwendt self-assigned this Mar 9, 2021
@davidwendt
davidwendt requested review from a team as code owners March 9, 2021 19:28
@davidwendt
davidwendt requested review from jrhemstad and trxcllnt March 9, 2021 19:28
@github-actions github-actions Bot added the CMake CMake build issue label Mar 9, 2021
@codecov

codecov Bot commented Mar 9, 2021

Copy link
Copy Markdown

Codecov Report

Merging #7541 (4ccedb6) into branch-0.19 (7871e7a) will increase coverage by 0.19%.
The diff coverage is 93.16%.

❗ Current head 4ccedb6 differs from pull request most recent head 9825ec8. Consider uploading reports for the commit 9825ec8 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.19    #7541      +/-   ##
===============================================
+ Coverage        81.86%   82.05%   +0.19%     
===============================================
  Files              101      101              
  Lines            16884    17008     +124     
===============================================
+ Hits             13822    13956     +134     
+ Misses            3062     3052      -10     
Impacted Files Coverage Δ
python/cudf/cudf/core/index.py 92.86% <ø> (ø)
python/cudf/cudf/core/series.py 91.33% <ø> (+0.55%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.44% <ø> (ø)
python/cudf/cudf/utils/cudautils.py 50.38% <ø> (ø)
python/cudf/cudf/utils/dtypes.py 89.88% <ø> (+0.37%) ⬆️
python/dask_cudf/dask_cudf/io/orc.py 91.04% <ø> (+0.13%) ⬆️
python/cudf/cudf/core/column/numerical.py 94.83% <87.50%> (-0.20%) ⬇️
python/cudf/cudf/core/frame.py 89.00% <89.47%> (-0.02%) ⬇️
python/cudf/cudf/core/column/column.py 87.77% <90.00%> (+0.01%) ⬆️
python/cudf/cudf/core/column/decimal.py 92.75% <90.32%> (-2.12%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4723051...9825ec8. Read the comment docs.

Comment thread cpp/src/strings/replace/backref_re_medium.cu
@davidwendt
davidwendt requested a review from codereport March 22, 2021 16:39
@harrism harrism removed the 3 - Ready for Review Ready for review by team label Mar 23, 2021
@harrism

harrism commented Mar 23, 2021

Copy link
Copy Markdown
Contributor

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit dd1f3ea into NVIDIA:branch-0.19 Mar 23, 2021
@davidwendt
davidwendt deleted the benchmark-strings-replace-re branch March 23, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants