Add explicit fixed_point merge test - #7635
Merged
Merged
Conversation
codereport
added
3 - Ready for Review
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7635 +/- ##
===============================================
+ Coverage 81.86% 82.04% +0.17%
===============================================
Files 101 101
Lines 16884 16991 +107
===============================================
+ Hits 13822 13940 +118
+ Misses 3062 3051 -11
Continue to review full report at Codecov.
|
karthikeyann
approved these changes
Mar 18, 2021
davidwendt
approved these changes
Mar 18, 2021
Contributor
Author
|
@gpucibot merge |
codereport
added
5 - Ready to Merge
harrism
approved these changes
Mar 18, 2021
| }; | ||
|
|
||
| template <typename T> | ||
| using fp_wrapper = cudf::test::fixed_point_column_wrapper<T>; |
Contributor
There was a problem hiding this comment.
Why is this using stmt outside the test and the rest are inside?
Contributor
Author
There was a problem hiding this comment.
You can't declare template inside GTEST macros:
../../../../tests/merge/merge_test.cpp:740:3: error: a template declaration cannot appear at block scope
template <typename T>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While confirming that libcudf does indeed support
cudf::mergewithfixed_pointended up writing an explicit test that there is no reason not to just add as a unit test.