Adds list.unique API - #7664
Merged
Merged
Conversation
Co-authored-by: GALI PREM SAGAR <sagarprem75@gmail.com>
ttnghia
requested changes
Mar 22, 2021
ttnghia
previously requested changes
Mar 23, 2021
kkraus14
reviewed
Mar 24, 2021
isVoid
marked this pull request as ready for review
March 30, 2021 22:11
kkraus14
approved these changes
Mar 30, 2021
ttnghia
approved these changes
Mar 31, 2021
Contributor
Author
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7664 +/- ##
===============================================
+ Coverage 81.86% 82.67% +0.80%
===============================================
Files 101 101
Lines 16884 17434 +550
===============================================
+ Hits 13822 14413 +591
+ Misses 3062 3021 -41
Continue to review full report at Codecov.
|
Contributor
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7414
This PR adds
list.uniqueAPI. FollowingSeries.uniquebehavior, this API treats null values as equal, and treats all nans as equal. This API does not guarantee the order of list elements. Example: