[REVIEW] Enable typecasting between decimal and int - #7691
Merged
Conversation
ChrisJar
changed the title
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7691 +/- ##
===============================================
+ Coverage 81.86% 82.52% +0.65%
===============================================
Files 101 101
Lines 16884 17447 +563
===============================================
+ Hits 13822 14398 +576
+ Misses 3062 3049 -13
Continue to review full report at Codecov.
|
ChrisJar
changed the title
Contributor
|
This is a workaround, not a fix. I would recommend figuring out what's wrong with the |
Contributor
ChrisJar
changed the title
ChrisJar
marked this pull request as ready for review
March 29, 2021 15:51
ChrisJar
changed the title
ChrisJar
changed the title
galipremsagar
added
bug
galipremsagar
approved these changes
Mar 29, 2021
isVoid
reviewed
Mar 29, 2021
Comment on lines
-83
to
+82
| result = libcudf.unary.cast(self, dtype) | ||
| if isinstance(dtype, cudf.core.dtypes.Decimal64Dtype): | ||
| result.dtype.precision = dtype.precision | ||
| return result | ||
| return libcudf.unary.cast(self, dtype) |
Contributor
There was a problem hiding this comment.
Just a quick side note that this is needed in #7716
galipremsagar
added
the
5 - Ready to Merge
Contributor
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables type conversions between
decimaltypes andinttypes.Closes #7440