[REVIEW] Reindex in DataFrame.__setitem__ - #7948
Merged
rapids-bot[bot] merged 2 commits intoApr 13, 2021
Merged
Conversation
galipremsagar
added
bug
Contributor
|
Does this change fix the following build error perchance? |
Contributor
Author
Yes, CI is currently blocked on this test failure and this PR addresses it. |
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #7948 +/- ##
===============================================
+ Coverage 82.30% 82.72% +0.42%
===============================================
Files 101 103 +2
Lines 17053 17714 +661
===============================================
+ Hits 14035 14654 +619
- Misses 3018 3060 +42
Continue to review full report at Codecov.
|
shwina
approved these changes
Apr 13, 2021
galipremsagar
added
5 - Ready to Merge
Contributor
Author
|
@gpucibot merge |
galipremsagar
added a commit
to galipremsagar/cudf
that referenced
this pull request
Apr 14, 2021
This PR fixes missing reindexing in `DataFrame.__setitem__` when the `value` argument is a `DataFrame`, we currently align index if `value` is a Series & `arg` is a column name already. This change is necessary to continue with the upgrade to pandas `1.2.4`, however pandas has confirmed this as a regression only in `1.2.0` and `1.2.2` hence corrected the pytest to only xfail in those versions of pandas. Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Ashwin Srinath (https://github.com/shwina) URL: NVIDIA#7948
kkraus14
pushed a commit
that referenced
this pull request
Apr 16, 2021
* Reindex in `DataFrame.__setitem__` (#7948) This PR fixes missing reindexing in `DataFrame.__setitem__` when the `value` argument is a `DataFrame`, we currently align index if `value` is a Series & `arg` is a column name already. This change is necessary to continue with the upgrade to pandas `1.2.4`, however pandas has confirmed this as a regression only in `1.2.0` and `1.2.2` hence corrected the pytest to only xfail in those versions of pandas. Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Ashwin Srinath (https://github.com/shwina) URL: #7948 * pin max pandas to 1.2.4
raydouglass
pushed a commit
that referenced
this pull request
Apr 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes missing reindexing in
DataFrame.__setitem__when thevalueargument is aDataFrame, we currently align index ifvalueis a Series &argis a column name already.This change is necessary to continue with the upgrade to pandas
1.2.4, however pandas has confirmed this as a regression only in1.2.0and1.2.2hence corrected the pytest to only xfail in those versions of pandas.