Don't reindex an new value on setitem if the original dataframe was empty - #8026
Merged
Conversation
vyasr
added
bug
kkraus14
reviewed
Apr 22, 2021
kkraus14
approved these changes
Apr 22, 2021
galipremsagar
requested changes
Apr 22, 2021
Co-authored-by: GALI PREM SAGAR <sagarprem75@gmail.com>
galipremsagar
approved these changes
Apr 22, 2021
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #8026 +/- ##
============================================
Coverage 82.74% 82.74%
============================================
Files 103 103
Lines 17702 17702
============================================
Hits 14648 14648
Misses 3054 3054
Continue to review full report at Codecov.
|
galipremsagar
added
! - Release
5 - Ready to Merge
kkraus14
added
! - Hotfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #8023. The
pandascompatibility patch in #7948 (and the backport to 0.19 in #7957) also needs to handle the case of assigning to an empty DataFrame.