Skip to content

support space in workspace - #7956

Merged
rapids-bot[bot] merged 7 commits into
branch-21.06from
workspace
May 27, 2021
Merged

support space in workspace#7956
rapids-bot[bot] merged 7 commits into
branch-21.06from
workspace

Conversation

@jolorunyomi

@jolorunyomi jolorunyomi commented Apr 14, 2021

Copy link
Copy Markdown
Contributor

Summary

Support space in WORKSPACE

@jolorunyomi
jolorunyomi requested review from a team as code owners April 14, 2021 15:00
@github-actions github-actions Bot added Java Affects Java cuDF API. gpuCI labels Apr 14, 2021
ajschmidt8
ajschmidt8 requested changes Apr 14, 2021
View reviewed changes

@ajschmidt8 ajschmidt8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a couple errors

Comment thread ci/gpu/build.sh Outdated
Comment thread ci/gpu/build.sh Outdated
Comment thread ci/gpu/build.sh Outdated
@jolorunyomi @ajschmidt8
Update ci/gpu/build.sh
415db7d 
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
@jolorunyomi
jolorunyomi requested a review from ajschmidt8 April 14, 2021 19:15
jolorunyomi and others added 2 commits April 14, 2021 14:16
@jolorunyomi @ajschmidt8
Update ci/gpu/build.sh
09f375e 
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
@jolorunyomi @ajschmidt8
Update ci/gpu/build.sh
9c487f3 
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
@jolorunyomi

jolorunyomi commented Apr 14, 2021

Copy link
Copy Markdown
Contributor Author

found a couple errors

Thanks for 👁️ @ajschmidt8

ajschmidt8
ajschmidt8 requested changes Apr 14, 2021
View reviewed changes

@ajschmidt8 ajschmidt8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found one more that might require review

Comment thread ci/cpu/build.sh Outdated
@jolorunyomi @ajschmidt8
Update ci/cpu/build.sh
d1c36fa 
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
@jolorunyomi
jolorunyomi requested a review from ajschmidt8 April 15, 2021 14:36
@github-actions

github-actions Bot commented May 15, 2021

Copy link
Copy Markdown

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@jolorunyomi jolorunyomi added the 2 - In Progress Currently a work in progress label May 24, 2021
@codecov

codecov Bot commented May 24, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@3da0d12). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 211118f differs from pull request most recent head a9c4b66. Consider uploading reports for the commit a9c4b66 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #7956   +/-   ##
===============================================
  Coverage                ?   82.89%           
===============================================
  Files                   ?      105           
  Lines                   ?    17875           
  Branches                ?        0           
===============================================
  Hits                    ?    14818           
  Misses                  ?     3057           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da0d12...a9c4b66. Read the comment docs.

@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 25, 2021
@harrism

harrism commented May 25, 2021

Copy link
Copy Markdown
Contributor

@jolorunyomi @ajschmidt8 should this be merged?

@jolorunyomi

jolorunyomi commented May 25, 2021

Copy link
Copy Markdown
Contributor Author

@jolorunyomi @ajschmidt8 should this be merged?

Yes please this should be merged

@harrism harrism added 5 - Ready to Merge Testing and reviews complete, ready to merge 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress 5 - Ready to Merge Testing and reviews complete, ready to merge labels May 26, 2021
@harrism

harrism commented May 27, 2021

Copy link
Copy Markdown
Contributor

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit b9bc78e into branch-21.06 May 27, 2021
@robertmaynard
robertmaynard deleted the workspace branch July 20, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes
@GaryShen2008 GaryShen2008 GaryShen2008 approved these changes

Assignees

No one assigned

Labels

3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jolorunyomi @harrism @ajschmidt8 @GaryShen2008