Support create lists column from a `list_scalar` by isVoid · Pull Request #8185 · NVIDIA/cudf

isVoid · 2021-05-07T19:04:00Z

This PR adds support to make_column_from_scalar for list_scalar. For 0-length columns, a well-formed LIST type column, whose child column has the same column hierarchy to the row data stored in list_scalar is returned.

Example:

slr.data = [1, 2, 3] // An integer list of 1, 2, 3, `data` is an INT column
make_column_from_scalar(s, 2) // List<int> column: {[1, 2, 3], [1, 2, 3]}, whose child column is an `INT` column.

slr.data = [[1, 2], [3]] // A list of integer lists, `data` is a List<int> column
make_column_from_scalar(s, 0) // Well formed, 0-length List<List<int>> column, whose child column is a List<int> column.

Closes #8088

codecov · 2021-05-07T21:57:17Z

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@8834ed6). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-21.06    #8185   +/-   ##
===============================================
  Coverage                ?   82.84%           
===============================================
  Files                   ?      105           
  Lines                   ?    17863           
  Branches                ?        0           
===============================================
  Hits                    ?    14798           
  Misses                  ?     3065           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8834ed6...23cb574. Read the comment docs.

…ist_column_from_scalar

harrism

I think stream and MR need to be used explicitly. Detail APIs should call detail APIs.

devavret

You can check in the beginning whether the size == 1 and make a mr that's either the default or the one passed in the arguments. Then you can use the same mr thoughout and avoid duplicating code.

ajschmidt8

Approving ops-codeowner file changes

…list_column_from_scalar

nvdbaranec · 2021-05-19T19:06:41Z

This PR ready to merge?

isVoid · 2021-05-19T21:47:25Z

Yup, I think it's good to go.

harrism · 2021-05-20T01:28:25Z

@isVoid you can merge with @gpucibot merge. And if you don't want to merge yourself, please use labels to indicate ready to merge.

harrism · 2021-05-20T01:28:45Z

@gpucibot merge

This small PR is to replace the JNI implementation with the corresponding cudf API `make_column_from_scalar`. The PR #8185 has added the support for nested type, so it is ok to do this now. Signed-off-by: Firestarman <firestarmanllc@gmail.com> Authors: - Liangcai Li (https://github.com/firestarman) Approvers: - Bobby Wang (https://github.com/wbo4958) - Robert (Bobby) Evans (https://github.com/revans2) - Jason Lowe (https://github.com/jlowe) URL: #8310

isVoid added 2 commits May 7, 2021 11:53

Initial under the hood impl

fc8172a

plumbing

ebaa0aa

github-actions Bot added CMake CMake build issue conda libcudf Affects libcudf (C++/CUDA) code. labels May 7, 2021

Move stuff into detail namespace

b608459

isVoid self-assigned this May 7, 2021

isVoid added 8 commits May 9, 2021 23:08

Merge branch 'branch-0.20' of https://github.com/rapidsai/cudf into l…

80ece91

…ist_column_from_scalar

Fix offset bug

8be39fb

Tests initial

e5ba865

strings test

99603ad

dictionary tests

1777fb7

lists of structs test

8e1f6bf

empty col hierarchy

365fb87

Refactor into lists_column_factories

0db5d60

github-actions Bot removed the CMake CMake build issue label May 11, 2021

isVoid marked this pull request as ready for review May 11, 2021 04:11

isVoid requested review from a team as code owners May 11, 2021 04:11

isVoid requested review from devavret and ramakrishnap-nv May 11, 2021 04:11

isVoid added feature request New feature or request 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels May 11, 2021

harrism suggested changes May 11, 2021

View reviewed changes

Comment thread cpp/src/lists/lists_column_factories.cu Outdated

Comment thread cpp/src/lists/lists_column_factories.cu Outdated

devavret requested changes May 12, 2021

View reviewed changes

Comment thread cpp/src/lists/lists_column_factories.cu Outdated

isVoid added 3 commits May 12, 2021 10:27

Rev: making sure mr is passed along

c0c1643

Use offset_type

87f7ba2

Use type_to_id

6b80ba4

Fix null_mask_state

f2824a6

isVoid requested review from devavret and harrism May 12, 2021 23:43

ajschmidt8 approved these changes May 13, 2021

View reviewed changes

isVoid commented May 13, 2021

View reviewed changes

Comment thread cpp/src/lists/lists_column_factories.cu Outdated

isVoid added 2 - In Progress Currently a work in progress and removed 3 - Ready for Review Ready for review by team labels May 13, 2021

isVoid added 2 commits May 13, 2021 14:13

Use view when size > 1

e28a1dd

Use stream, mr in nullmask for size == 0

c2afef0

isVoid added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels May 13, 2021

devavret approved these changes May 14, 2021

View reviewed changes

harrism approved these changes May 18, 2021

View reviewed changes

ajschmidt8 changed the title ~~Support create lists column from a list_scalar~~ Support create lists column from a list_scalar May 18, 2021

isVoid added 3 commits May 18, 2021 17:24

Merge branch 'branch-21.06' of https://github.com/rapidsai/cudf into …

71be428

…list_column_from_scalar

Make empty columns

150e2c9

Update column_factories.cu

23cb574

harrism added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels May 20, 2021

rapids-bot Bot merged commit c732cef into NVIDIA:branch-21.06 May 20, 2021

firestarman mentioned this pull request May 21, 2021

JNI: Refactor the code of making column from scalar [skip ci] #8310

Merged

Navigation Menu

Uh oh!

Support create lists column from a `list_scalar` - #8185

Support create lists column from a `list_scalar`#8185
rapids-bot[bot] merged 20 commits into
NVIDIA:branch-21.06from
isVoid:list_column_from_scalar

isVoid commented May 7, 2021 •

edited

Loading

Uh oh!

codecov Bot commented May 7, 2021 •

edited

Loading

Uh oh!

harrism left a comment

Uh oh!

Uh oh!

Uh oh!

devavret left a comment

Uh oh!

Uh oh!

ajschmidt8 left a comment

Uh oh!

Uh oh!

nvdbaranec commented May 19, 2021

Uh oh!

isVoid commented May 19, 2021

Uh oh!

harrism commented May 20, 2021

Uh oh!

harrism commented May 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

isVoid commented May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

harrism left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

devavret left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ajschmidt8 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

nvdbaranec commented May 19, 2021

Uh oh!

isVoid commented May 19, 2021

Uh oh!

harrism commented May 20, 2021

Uh oh!

harrism commented May 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

isVoid commented May 7, 2021 •

edited

Loading

codecov Bot commented May 7, 2021 •

edited

Loading