Revert "patch thrust to fix intmax num elements limitation in scan_by_key" - #8226
Closed
cwharris wants to merge 2 commits into
Closed
Revert "patch thrust to fix intmax num elements limitation in scan_by_key"#8226cwharris wants to merge 2 commits into
cwharris wants to merge 2 commits into
Conversation
github-actions
Bot
added
CMake
cwharris
added
non-breaking
kkraus14
approved these changes
May 12, 2021
davidwendt
approved these changes
May 12, 2021
elstehle
approved these changes
May 12, 2021
kkraus14
added
5 - Ready to Merge
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #8226 +/- ##
=============================================
Coverage 82.88% 82.89%
=============================================
Files 103 104 +1
Lines 17668 17916 +248
=============================================
+ Hits 14645 14851 +206
- Misses 3023 3065 +42
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #8199
According to @allisonvacanti (NVIDIA/thrust#1424 (comment)) this patch will likely have adverse effect on performance. We should revert it until a better solution can be found.