Skip to content

Adding bins to value counts - #8247

Merged
rapids-bot[bot] merged 72 commits into
NVIDIA:branch-22.08from
marlenezw:bins_to_value_counts
Jul 15, 2022
Merged

Adding bins to value counts#8247
rapids-bot[bot] merged 72 commits into
NVIDIA:branch-22.08from
marlenezw:bins_to_value_counts

Conversation

@marlenezw

Copy link
Copy Markdown
Contributor

This PR aims to add bins to Series.value counts in cudf. It contributes towards addressing issue 1061. This issue also depends on the completion of cudf.cut and includes changes that are being reviewed in PR #8002

…s. Also handling for drop and raise duplicates.
@vyasr
vyasr force-pushed the bins_to_value_counts branch from 8129248 to 37f24cd Compare July 12, 2022 23:54
@github-actions github-actions Bot added Python Affects Python cuDF API. and removed libcudf Affects libcudf (C++/CUDA) code. gpuCI CMake CMake build issue labels Jul 12, 2022
@vyasr
vyasr removed request for a team, davidwendt and jrhemstad July 12, 2022 23:59
@vyasr vyasr self-assigned this Jul 12, 2022
@vyasr vyasr added 3 - Ready for Review Ready for review by team and removed 0 - Waiting on Author Waiting for author to respond to review inactive-90d labels Jul 12, 2022
@vyasr

vyasr commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

@marlenezw just a heads up, I'm planning to finish this PR up for you. Thanks for getting us this far!

@galipremsagar galipremsagar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vyasr I went through the current state of the PR and requested changes.

Comment thread python/cudf/cudf/core/column/categorical.py Outdated
Comment thread python/cudf/cudf/core/column/categorical.py Outdated
Comment thread python/cudf/cudf/core/series.py Outdated
Comment thread python/cudf/cudf/tests/test_series.py Outdated
Comment thread python/cudf/cudf/tests/test_series.py Outdated
@vyasr
vyasr requested review from galipremsagar and isVoid July 13, 2022 23:25
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Jul 15, 2022
@galipremsagar

Copy link
Copy Markdown
Contributor

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit a9d340e into NVIDIA:branch-22.08 Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants